JSON Schema - include latest spec updates around CredSchema/digestSRI #455
Conversation
decentralgabe
commented
Aug 29, 2023
decentralgabe
commented
- Add enforcement of credential schema for json schema credentials and associated tests
decentralgabe
requested review from
nitro-neal and
andresuribe87
as code owners
Codecov Report
@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 57.35% 57.42% +0.07%
==========================================
Files 67 67
Lines 7479 7499 +20
==========================================
+ Hits 4289 4306 +17
- Misses 2454 2455 +1
- Partials 736 738 +2
|
There was a problem hiding this comment.
We will also need to validate that a VC that's setting the credentialSchema.digestSRI property, has a value which matches against the locally calculated digestSRI. This typically involves dereferencing credentialSchema.id, and then following the spec of SubResource Integrity.
I would prefer that we do that in this PR, so that the same mechanism is used for every VC (instead of special casing VCs who's type property is JsonSchemaCredential). That said, I'd understand leaving that for another PR. Up to you.
|
I'd rather take that in a separate PR, but opened an issue #456 |
